crytic / crytic/slither

[False-Positive]: `constable-states` false positive introduced in `0.11.0`

Open
#2,659 4 comments 0 reactions 0 assignees View on GitHub
false-positive
Dominant language
Python
Stars
6.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

### Describe the false alarm that Slither raise and how you know it's inaccurate:

See [this](https://github.com/OpenZeppelin/openzeppelin-contracts/actions/runs/13122640869/job/36613400266) action run. There is a new false positive introduced in `0.11.0` where the strings mentioned below are now tagged for being constable.

### Frequency

Occasionally

### Code example to reproduce the issue:

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/19c2f2f5a5ea43e18dfff2b92b54b76815783d93/contracts/utils/cryptography/EIP712.sol#L51-L52

### Version:

0.11.0

### Relevant log output:

```shell
EIP712._nameFallback (contracts/utils/cryptography/EIP712.sol#51) should be constant
EIP712._versionFallback (contracts/utils/cryptography/EIP712.sol#52) should be constant
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.