crytic / crytic/slither

API change: rename sons/father to next/predecessor in nodes

Open
#2,398 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
6.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

I think next/predecessor will be more intuitive than sons/father for the CFG (https://github.com/crytic/slither/blob/master/slither/core/cfg/node.py)

This will be a breaking change, but most likely not too many external code relies on this.

I would in favor to keep in parallel keep `sons` and `fathers` for a few iteration but making it clear that they are deprecated

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.