Incorrect detector results to investigate
- Dominant language
- Python
- Stars
- 6.4k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
From @pcaversaccio
## 1
- Detector arbitrary-send-eth is correctly found here: https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L159
- But it doesn't detect it here: https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L374 and here https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L694
## 2
- The same line allows actually for reentrancy: https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L159 but it doesn't get detected (I only exclude reentrancy-events in the config)
Contributor guide
Research direction
Start with the arbitrary-send-eth and reentrancy detectors, then reproduce both reports against the linked CreateX.sol lines 159, 374, and 694. Compare the detector results with the issue’s expected findings and document or test the corrected behavior for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, solidity
- Domain
- devtools, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100