crytic / crytic/slither

[False-Positive]: "ignores return value" false positive

Open
#2,126 0 comments 0 reactions 0 assignees View on GitHub
false-positive
Dominant language
Python
Stars
6.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

### Describe the issue:

slither says that i'm ignoring the return value

https://github.com/rainprotocol/rain.flow/actions/runs/6138590436/job/16655608341?pr=5#step:4:57965

```
FlowERC1155._previewFlow(Evaluable,uint256[][]) (src/concrete/erc1155/FlowERC1155.sol#133-153) ignores return value by (stackTop,tuplesPointer) = stackBottom.consumeSentinelTuples(stackTop,RAIN_FLOW_ERC1155_SENTINEL,3) (src/concrete/erc1155/FlowERC1155.sol#143)
FlowERC1155._previewFlow(Evaluable,uint256[][]) (src/concrete/erc1155/FlowERC1155.sol#133-153) ignores return value by (stackTop,tuplesPointer) = stackBottom.consumeSentinelTuples(stackTop,RAIN_FLOW_ERC1155_SENTINEL,3) (src/concrete/erc1155/FlowERC1155.sol#148)
```

but it isn't ignored, both return values are used

https://github.com/rainprotocol/rain.flow/pull/5/files#diff-0bfdd537a599fa870763c6915d4a43184ba4ef54bc038e33bd9d3545a445c4b0R143

### Code example to reproduce the issue:

https://github.com/rainprotocol/rain.flow/pull/5/files#diff-0bfdd537a599fa870763c6915d4a43184ba4ef54bc038e33bd9d3545a445c4b0R142

### Version:

latest according to github actions

### Relevant log output:

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.