reentrancy benign enhancements
- Dominant language
- Python
- Stars
- 6.4k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
This should be detected and flagged as higher severity, but it's only detected as reentrancy-benign: `slither ftm:0x660184CE8AF80e0B1e5A1172A16168b15f4136bF --detect reentrancy-benign`. We may be able to infer that calls to `transferFrom`/ `balanceOf` is equivalent to a read-after-write by modeling the storage of the other contract.
_Originally posted by @0xalpharush in https://github.com/crytic/slither/issues/1523#issuecomment-1362206044_
Contributor guide
Research direction
Start with the reentrancy-benign detector and reproduce the behavior using the Slither command shown in the issue. Investigate whether modeling another contract's storage can distinguish transferFrom or balanceOf calls as read-after-write operations; done means the case is flagged with higher severity and covered by an appropriate regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, solidity
- Domain
- blockchain, devtools, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100