crytic / crytic/slither

Improve reentrancy-event to better support cross function risks

Open
#1,482 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
6.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

With https://github.com/crytic/slither/pull/1351, we removed a lot of FPs due to `nonReentrant`. However at the same time we removed TP for cross function reentrancy that can lead to have events in the incorrect order. See https://github.com/crytic/slither/pull/1351#issue-1341663766.

We should improve the detector to catch these edge cases

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.