crytic / crytic/slither-action

Make install_node optional

Open
#63 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
142
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Installing node/ nvm can lead to a lot of wasted ressources. We should make it optional - in particular if the project only use foundry

https://github.com/crytic/slither-action/blob/5c7580c54648c48c709498dc7acb7133a89db179/entrypoint.sh#L129C1-L149

See an example where nvm install takes forever: https://github.com/pcaversaccio/createx/actions/runs/6716947847/job/18291251493?pr=23#step:18:184

Contributor guide

No contributing guide indexed for this repository

Research direction

Read entrypoint.sh lines 129-149, then compare the install flow with the linked Foundry-only workflow example. Identify how the action determines whether Node is needed and make the Node/nvm installation skippable for projects that do not use it. Done means a Foundry-only run no longer waits for nvm installation while Node-dependent projects retain their setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.