crytic / crytic/properties

[Bug-Candidate]: `PropertiesConstants.INITIAL_BALANCE` is an arbitrary value unrelated to Echidna default setup

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Solidity
Stars
371
Forks
59
PR merge metrics
No merged PRs in 30d

Description

### Describe the issue:

The `PropertiesConstants` contracts contain some hardcoded parameters that are related to Echidna's default setup, such as `USER1`, `USER2`, and `USER3`.

The issue is that it also contains `INITIAL_BALANCE`, which has nothing to do with `balanceAddr` or `balanceContract`. This can be confusing to users.

Maybe it is better to migrate this value to another contract and create the related `BALANCE_ADDR` or `BALANCE_CONTRACT` variables.

### Steps to reproduce the issue:

N/A

### If additional code is needed for reproducing, please copy it here, or drop us a link to the repository:

N/A

### Echidna version:

N/A

### Additional information:

```shell
N/A
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.