crytic / crytic/crytic-compile

`parse_standard_json_output` shall skip filename verification

Open
#495 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
197
Forks
97
PR merge metrics
No merged PRs in 30d

Description

When trying to compile a solc JSON input, crytic-compile tries to verify all filename inside JSON. However, most of the time, when we use `parse_standard_json_output`, the file does not really exist. Is it possible to skip filename verification?

```
from crytic_compile.platform.solc_standard_json import SolcStandardJson
a = SolcStandardJson("slither/compiler.json")
from crytic_compile import CryticCompile
CryticCompile(a)
```

=>

```
Traceback (most recent call last):
File "/Users/shou/PycharmProjects/slither/venv/lib/python3.9/site-packages/crytic_compile/crytic_compile.py", line 554, in _compile
self._platform.compile(self, **kwargs)
File "/Users/shou/PycharmProjects/slither/venv/lib/python3.9/site-packages/crytic_compile/platform/solc_standard_json.py", line 469, in compile
parse_standard_json_output(
File "/Users/shou/PycharmProjects/slither/venv/lib/python3.9/site-packages/crytic_compile/platform/solc_standard_json.py", line 309, in parse_standard_json_output
path = convert_filename(
File "/Users/shou/PycharmProjects/slither/venv/lib/python3.9/site-packages/crytic_compile/utils/naming.py", line 169, in convert_filename
filename = _verify_filename_existence(filename, cwd)
File "/Users/shou/PycharmProjects/slither/venv/lib/python3.9/site-packages/crytic_compile/utils/naming.py", line 119, in _verify_filename_existence
raise InvalidCompilation(f"Unknown file: {filename}")
crytic_compile.platform.exceptions.InvalidCompilation: Unknown file: main.sol
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.