crytic / crytic/crytic-compile

unify all platforms to use `run` utility instead of directly invoking subprocess.Popen

Open
#430 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
197
Forks
97
PR merge metrics
No merged PRs in 30d

Description

Using the following will ensure we have consistent logging and handle errors consistently throughout all the platforms
https://github.com/crytic/crytic-compile/blob/10104f33f593ab82ba5780a5fe8dd26385acd1c1/crytic_compile/utils/subprocess.py#L14

Contributor guide

Open the contributing guide

Research direction

Start with crytic_compile/utils/subprocess.py at the referenced utility, then locate platform implementations that invoke subprocess.Popen directly. Review each platform path for the existing subprocess calls and compare them with the utility's logging and error handling. Done means all platform subprocess execution uses the run utility consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.