crytic / crytic/crytic-compile

Parse etherscan response code to improve error message displayed to user

Open
#233 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
197
Forks
97
PR merge metrics
No merged PRs in 30d

Description

When Etherscan rate-limits crytic-compile the following message is displayed.
```
ERROR:CryticCompile:Contract has no public source code: https://api-rinkeby.etherscan.io/api?module=contract&action=getsourcecode&address=0x85E2B172e94Ed1d23D3bc078F327b44736887Db9
```
Etherscan returns a 200 HTTP with the following json response:
```
{"status":"0","message":"NOTOK","result":"Max rate limit reached, please use API Key for higher rate limit"}
```

I've asked if they can return a 429 so we don't have to parse the response body, and I'll implement accordingly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.