cryptomator / cryptomator/hub

Deduplicate syncUser and syncGroup logic in KeycloakAdminService

Open
#386 0 comments 0 reactions 1 assignee Claimed by @overheadhunter View on GitHub
Dominant language
Java
Stars
80
Forks
15
PR merge metrics
No merged PRs in 30d

Description

## Description

The `syncUser` and `syncGroup` methods in `KeycloakAdminService` duplicate logic from `KeycloakAuthorityPuller`. Both synchronization methods should share the same implementation to maintain consistency.

## Affected Code

- `syncUser` method (line ~183 in KeycloakAdminService.java)
- `syncGroup` method (line ~214 in KeycloakAdminService.java)

Both methods have TODO comments indicating the need for deduplication with `KeycloakAuthorityPuller`.

## Related PR

- PR: https://github.com/cryptomator/hub/pull/376
- Review Comment: https://github.com/cryptomator/hub/pull/376#discussion_r2671912297

## Requested by

@overheadhunter

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.