cryptomator / cryptomator/android

Better notification when authentication fails due to "LiveStatus: NOT_CONNECTED" which means Cryptomator have no rights to access OneDrive

Open
#367 0 comments 0 reactions 0 assignees View on GitHub
good first issue storage:onedrive type:feature-request
Dominant language
Kotlin
Stars
1.2k
Forks
216
PR merge metrics
No merged PRs in 30d

Description

### Please agree to the following

- [X] I have searched [existing issues](https://github.com/cryptomator/android/issues?q=) for duplicates
- [X] I agree to follow this project's [Code of Conduct](https://github.com/cryptomator/android/blob/develop/.github/CODE_OF_CONDUCT.md)

### Summary

Better notification when authentication fails due to "LiveStatus: NOT_CONNECTED" which means Cryptomator have no rights to access OneDrive

### Motivation

Currently only an authentication failed notification is shown when the credentials are correct but the Cryptomator application isn't allowed to access the OneDrive storage due to e.g. Admin restrictions. This error is detectable using the `LiveStatus` and can be explained to the user in a better way than showing the generic authentication failed message.

### Considered Alternatives

_No response_

### Anything else?

```
D MSAAuthAndroidAdapter LiveStatus: NOT_CONNECTED, LiveConnectSession good?: true, UserState null
E MSAAuthAndroidAdapter org.cryptomator.data.cloud.onedrive.graph.ClientException: Unable to login successfully
at org.cryptomator.data.cloud.onedrive.graph.MSAAuthAndroidAdapter$2.onAuthComplete(MSAAuthAndroidAdapter.java:165)
at com.microsoft.services.msa.LiveAuthClient$3.doInBackground(LiveAuthClient.java:435)
at com.microsoft.services.msa.LiveAuthClient$3.doInBackground(LiveAuthClient.java:424)
at android.os.AsyncTask$3.call(AsyncTask.java:394)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:923)

ErrorCode: NGHF:9IMG
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.