cryptoadvance / cryptoadvance/specter-diy

[feature Request] High fee warning

Open
#324 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
585
Forks
108
Avg merge
6d 1h
Merged PRs (30d)
5

Description

I think it would be cool if the Hardware Wallet would warn you. If you are about to make a transaction with a disproportionate high transaction fee.

Maybe something like:
more than 20% of the amount with transactions above 100 000 sats
more than 30% of the amount with transactions under 100 000 sats

And maybe a relative amount if sats/vbyte is very high.

Maybe like 100 sats per vbyte -> warning high fee

300 sats per vbyte -> warning very high fee

I think this could protect users from accidently signing a transaction with to high transaction fees.
![Image](https://github.com/user-attachments/assets/07ec5a3a-1cb8-4751-a6c9-bae2bb99a474)

P.S.
Maybe it would be cool to have the sats/vbyte rate displayed at the hardware Wallet as well. Maybe in the advanced settings. (if this could be easily implemented)
![Image](https://github.com/user-attachments/assets/1ee06df7-b4c0-4889-b662-29e938f6eba9)

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue names no files or tests. Start by tracing the hardware wallet's transaction-signing flow and any existing fee or sats-per-vbyte display, then clarify which warning thresholds and display changes are required. Done means the agreed high-fee cases are detected before signing and the resulting warning behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.