cryptoadvance / cryptoadvance/specter-diy

Account indexing - confusion with other wallets

Open
#322 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
585
Forks
108
Avg merge
6d 1h
Merged PRs (30d)
5

Description

[BIP-44](https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki)/[BIP-84](https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki) specify that account numbering should start from zero.

However, some of the most popular hardware wallets (Trezor, Ledger, etc.) start counting from 1 - i.e. `"Account #1"` represents `m/84h/0h/0h`, `"Account #2"` represents `m/84h/0h/1h`, etc.

This might confuse users migrating from/to Specter DIY, even though Specter DIY did follow the correct spec.

I recommend writing some comment about the issue wherever an account-number is displayed. Preferably also show the matching derivation path below the account-number.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.