cryptoadvance / cryptoadvance/specter-diy
'+Create Wallet' Button creates pitfall (Multisig)
- Dominant language
- Python
- Stars
- 585
- Forks
- 108
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 5
Description
On the default screen for exporting a Multisig key there is a '+Create wallet' button which will lead users to create a single sig wallet (p2wpkh) using default multisig derivation (m/48'/1'/0'/2'). The button is missleading in this place since users might press the button, go to the Wallets App and export information to the co-ordinator from here (and end up with a wpkh key in their co-ordinator software).
To reproduce:
- _Main screen > Master public keys > Multisig_
"Your master public key" screen: The information for canonical xpub as well as SLIP-132 shows pubkey information adhering to multisig defaults
- _'+Create wallet' > Native Segwit > "Name your Wallet" > Done_
"Add wallet" screen: toggling to SLIP-132 shows vpub notation (lower case v) and does therefore not match the defaults for a multisig P2WSH key (Vpub)
- _'Confirm'_ (Wallet propagates to Wallets menu).
//edit: I'm on testnet, but same goes for other networks
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.