cryptoadvance / cryptoadvance/specter-diy
PSBT_TAP_KEY_SIG not supported
- Dominant language
- Python
- Stars
- 585
- Forks
- 108
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 5
Description
Signing w/ the taproot internal key looks not implemented, [cf here](https://github.com/diybitcoinhardware/f469-disco/blob/master/libs/common/embit/psbt.py#L353)
signing w/ taptree works fine, can be tested on liana w/ this [PR](https://github.com/wizardsardine/liana/pull/1103)
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at libs/common/embit/psbt.py around line 353, where the issue reports that internal-key Taproot signing is not implemented. Use the liana PR #1103 scenario to exercise the behavior, and compare it with the existing taptree signing path. Done means PSBT_TAP_KEY_SIG signing works for the Taproot internal key without breaking taptree signing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cryptography
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100