cryptoadvance / cryptoadvance/specter-desktop

WalletManager not aware of different Core-Versions (if more than one node configured)

Open
#2,077 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
847
Forks
259
Avg merge
6d 18h
Merged PRs (30d)
2

Description

The WalletManager is currently initialized with a `bitcoin_core_version_raw`. However, the wallet_manager is also a long living object managing more than one core-connection. Therefore the `bitcoin_core_version_raw` needs to be specific to the corresponding node-connection.

`bitcoin_core_version_raw` is used in the `create_wallet` method and needs to get fixed so that it's always asking the rpc for that info.

Contributor guide

Open the contributing guide

Research direction

Start by locating WalletManager and its create_wallet method, then trace how each configured node connection exposes its RPC. Check where bitcoin_core_version_raw is initialized and used, and verify that create_wallet requests the version from the RPC associated with the node being managed rather than sharing one value across connections.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.