cryptoadvance / cryptoadvance/specter-desktop

"Subtract fees from amount" should show the final payment amount

Open
#2,031 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
847
Forks
259
Avg merge
6d 18h
Merged PRs (30d)
2

Description

When sending a new transaction, there is a checkbox option to "Subtract fees from amount". This is a good option to have, and is the default when you 'send max' when you are emptying your entire wallet.

In this case, the fee must naturally be deducted from your max funds. There is a small gray text link which says "Calculate estimated fee" which is good, but I think this should be done automatically whenever this checkbox is checked, and there should be a display with what the final txn amount will be.

Easier to explain with pictures:

Current:

![image](https://user-images.githubusercontent.com/1900684/209361839-0bb6cc24-c880-4e54-afc2-e6a0af09be44.png)

Requested (green minus red equals blue):

![image](https://user-images.githubusercontent.com/1900684/209362528-8cd43cab-f163-41d4-b17e-6e8b01c76b5d.png)

And then that white box could update automatically as you drag the fee slider.

PS: the RBF checkbox is overlapping that "Coin Selection" expand button... might be because of scaling issues, i'm on 125% scaling in Windows

Contributor guide

Open the contributing guide

Research direction

Start by locating the transaction-send form and the controls labeled "Subtract fees from amount" and "Calculate estimated fee". Trace how the fee slider and estimated fee currently affect the transaction amount. Done means the estimate runs automatically when subtraction is enabled, the final transaction amount is displayed and updates with the fee slider, and the reported RBF/Coin Selection overlap is investigated.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop, payments
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.