cryptoadvance / cryptoadvance/specter-desktop
Creating a Wallet with Same Keys Creates Duplicate Wallet
- Dominant language
- Python
- Stars
- 847
- Forks
- 259
- Avg merge
- 6d 18h
- Merged PRs (30d)
- 2
Description
When creating a wallet, if you define a wallet with the same device pool and same parameters (x of y multi-sig), Specter will create a duplicate of an existing wallet if a wallet with the same parameters had already been created previously.
**To Reproduce**
Steps to reproduce the behavior:
1. Create a wallet with some specific devices and parameters (2 of 3 for example)
2. Transfer a balance into the wallet
3. Create a second wallet with identical parameters
4. Note that the second wallet has the same balance and transaction history as the first wallet.
**Expected behavior**
I expected Specter to create the second wallet as a unique and different wallet.
**Desktop (please complete the following information):**
- Where is your node running: local Bitcoin Core
- Where is your specter running: local binary
- If you're running a binary, which OS: Windows 11
- Browser Chrome
- Specter Version 1.9.2
**Additional context**
This issue can likely be fixed by allowing the user to increment the derivation paths of one or more device's keys so that the same set of keys is not used for the second wallet even though it is the same pool of signing devices.
Contributor guide
Research direction
Reproduce the duplicate-wallet behavior using local Bitcoin Core and the wallet-creation flow described in the issue. Trace how identical device pools and multisig parameters select derivation paths; done means creating the second wallet produces distinct balance and transaction history rather than reusing the first wallet.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- blockchain, desktop
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100