cryptoadvance / cryptoadvance/specter-desktop

No checks for wallet creation with non-standard keys

Open
#1,329 1 comment 0 reactions 1 assignee Claimed by @moneymanolis View on GitHub
Dominant language
Python
Stars
847
Forks
259
Avg merge
6d 18h
Merged PRs (30d)
2

Description

When importing keys via custom derivation there is currently no sanity / typo check. For example, it is currently possible to create a wallet with the keys in the screenshot.

grafik

#1328 would address this by having a symbol with a warning text regarding the network when hovering over it:

grafik

It also looks like the mentioned PR restricts the possible keys to be used (only standard purposes) as the second key is no longer displayed. Should be discussed when reviewing the PR @k9ert

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.