cryostatio / cryostatio/cryostat-openshift-console-plugin

[Task] Investigate what PF stylesheets are provided by each version of the Console

Open
#128 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
6
Avg merge
15h 47m
Merged PRs (30d)
11

Description

Issue https://github.com/cryostatio/cryostat-openshift-console-plugin/issues/125 was concerned with missing description-list styling for the Topology page, and we had https://github.com/cryostatio/cryostat-openshift-console-plugin/issues/101 track missing overflow-menu styling in the Recordings page.

In both of these cases, the required PF stylesheets were missing when running in CRC at 4.17, but looked to be okay when using 4.19.

PR https://github.com/cryostatio/cryostat-openshift-console-plugin/pull/126 added imports for the missing stylesheets so they would be present in all console versions, but it is worthwhile investigating _why_ this is the case.

A potential cause could be the supported PF versions for different versions of the console. The table [here](https://github.com/openshift/console/tree/master/frontend/packages/console-dynamic-plugin-sdk#openshift-console-versions-vs-patternfly-versions) shows that up until 4.19 the console supports both PF 4 and 5, whereas 4.19 supports only 5. This will be important to track and understand going forward as I already see the commits to update to PF6.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with issues #125 and #101, PR #126, and the OpenShift Console dynamic-plugin SDK's console-versus-PatternFly version table. Compare which PatternFly stylesheets are provided by the relevant Console versions, especially CRC 4.17 and Console 4.19. Done means the version-specific stylesheet differences and their likely cause are documented, including implications for the planned PF6 update.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.