crossplane / crossplane/upjet

Upjet resources do not set observedGeneration in the Synced condition

Open
#591 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Go
Stars
481
Forks
131
Avg merge
2d 1h
Merged PRs (30d)
11

Description

### What happened?
upjet resources are not setting the `observedGeneration` in the `Synced` condition which causes the `lastTransitionTime` to be updated on every reconciliation cycle.

See https://github.com/crossplane/crossplane-runtime/issues/902 for more details.

### How can we reproduce it?
Create an upjet-based resource and put a watch on it. Observe that the resource is updated on every pollInterval and the only change is the `lastTransitionTime` in the `Synced` condition.

`WithObservedGeneration()` needs to be added to the `ReconcileSuccess()` conditions (and possibly others?)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.