crossplane / crossplane/upjet

[v2] namespaced resources don't have clean/tested examples

Open
#542 3 comments 0 reactions 0 assignees View on GitHub
v2
Dominant language
Go
Stars
481
Forks
131
Avg merge
2d 1h
Merged PRs (30d)
11

Description

In the v2 compatible preview of provider-upjet-aws, we generate examples content for both cluster scoped and namespaced resources in the [examples-generated](https://github.com/crossplane-contrib/provider-upjet-aws/tree/crossplane-v2/examples) directory.

However, these generated examples have not been cleaned and tested with `uptest`, so there are 0 namespaced examples in the [examples](https://github.com/crossplane-contrib/provider-upjet-aws/tree/crossplane-v2/examples) directory. We even skip checking the namespaced resources for examples in the [check-examples.py](https://github.com/crossplane-contrib/provider-upjet-aws/blob/crossplane-v2/scripts/check-examples.py#L55) script - we should probably not do this long term.

I'm not entirely familiar with the process, but it's my understanding that this has historically been somewhat manual. That would be a large investment of time and energy to manually get these generated examples tested and committed.

Questions:

* Is there a better approach where we can take the tested examples of cluster scoped resources and transform them automatically into namespaced variants?
* Would the `xpkg batch` command need to be updated in order to process namespaced examples too?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.