crossplane / crossplane/crossplane-runtime
APIRecorder uses deprecated record.EventRecorder and drops filterFns
- Dominant language
- Go
- Stars
- 198
- Forks
- 161
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
## Problem
1. `NewAPIRecorder` accepts `record.EventRecorder` which is deprecated in favor of `events.EventRecorder` (`events.k8s.io/v1` API)
2. `WithAnnotations` silently drops `filterFns` on every call due to not forwarding them to `NewAPIRecorder`
3. `FilterFn` godoc incorrectly states return false prevents recording (should be return true)
4. `Eventf` call passes empty action string, which can cause `events.k8s.io/v1` rejection
## Related PR
#1052
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating NewAPIRecorder, WithAnnotations, FilterFn, and Eventf in the recorder package. Review related PR #1052 and any nearby tests or call sites to understand the current behavior. Done means the four listed API, filter forwarding, documentation, and action-string problems are corrected without dropping existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100