crossplane-contrib / crossplane-contrib/provider-upjet-github

Rate limit handling

Open
#137 32 comments 3 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
56
Forks
46
Avg merge
6d 7h
Merged PRs (30d)
2

Description

Hello
I'm struggling to find if and how the provider supports Github rate limits handling.

We have many Github resources handled by this provider and what we're experiencing is that we hit Github rate limits.

What I think is the reason why is that we have some managed resources which cannot be created and sit there consuming reconciliation loops.

I tried to set [write_delay_ms](https://registry.terraform.io/providers/integrations/github/latest/docs#write_delay_ms-1) and read_delay_ms settings but it seems it doesn't fix the issue.

I also read about --max-reconcile-rate and --poll settings but I didn't know if the provider supported them until I dag into the code:
https://github.com/crossplane-contrib/provider-upjet-github/blob/bf4fac6b683c8093c8a3315d1bc0b0d7c9be175e/cmd/provider/main.go#L47-L50

Anyway I'm not sure it that would help. Does the default values mean that there should be 100 concurrent API calls to Github every 10 minutes?
Any suggestion?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.