crossplane-contrib / crossplane-contrib/function-patch-and-transform

Composite showing ready status when one of the resources cannot render

Open
#12 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
46
Forks
41
Avg merge
1d 10h
Merged PRs (30d)
3

Description

In porting over [platform-ref-aws](https://github.com/upbound/platform-ref-aws) to P&T, I noticed that the Helm releases were unhealthy, but the overall composite showed healthy:

```
kubectl get composite
xeks.aws.platformref.upbound.io/borrelli-function-test-9pq6z-62qdh True True xeks.aws.platformref.upbound.io 70m
```

This helm ProviderConfig and KubernetesClusterAuth not generating was due to a patch that needed a field `Type` added to it:

```
transforms:
- type: string
string:
type: Format # missing
fmt: "%s-ekscluster"
```

```
Warning ComposeResources 4m48s (x43 over 70m) defined/compositeresourcedefinition.apiextensions.crossplane.io Pipeline step "patch-and-transform": cannot render FromComposite patches for composed resource "kubernetesClusterAuth": cannot apply the "FromCompositeFieldPath" patch at index 1: transform at index 0 returned error: string transform could not resolve: type is not supported for string transform type
```

I believe this composite should have shown that it could not render a resource:

```
Status:
Conditions:
Last Transition Time: 2023-09-30T07:11:06Z
Reason: ReconcileSuccess
Status: True
Type: Synced
Last Transition Time: 2023-09-30T08:19:07Z
Reason: Available
Status: True
Type: Ready
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.