crossoverJie / crossoverJie/cim
请求路由的代码觉得可以优化下
- Dominant language
- Java
- Stars
- 9.5k
- Forks
- 2.9k
- PR merge metrics
- No merged PRs in 30d
Description
路由请求看着是用ProxyManager创建代理还要传入 okHttpclient,还有设置url,请求完还要在代码里转换response,感觉这一块代码可以封装一下,或者用RestTemplate或者feign感觉都会更好,或者建公用的类进行相应的处理,,这样就不用再代码里面 又要new 又要转换对象了又要传url了.
bug:RouteRequestImpl.getCIMServer的时候如果用户不存在会因为要拿是否重连的标志导致空指针异常
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at RouteRequestImpl.getCIMServer and trace the user-not-found path, including how the reconnect flag is read. Review the ProxyManager and OkHttpClient request flow, then compare the existing response conversion with the proposed shared request handling; done means the null case is safe and the intended request abstraction is defined and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100