crossbario / crossbario/autobahn-python
ApplicationRunner should not auto_reconnect after failed login
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.5k
- Forks
- 768
- PR merge metrics
- No merged PRs in 30d
Description
When auto_reconnect is enabled, the ApplicationRunner does not know whether or not it ever successfully connected in the first place. As a result, connections lost due to incorrect login information are constantly re-attempted with the same incorrect information.
A check that prevents this exists in Autobahn JS:
https://github.com/crossbario/autobahn-js/blob/master/lib/connection.js#L349
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Python ApplicationRunner logic for auto_reconnect and compare its behavior with the linked Autobahn JS connection.js check. Confirm how failed initial login differs from a connection lost after a successful connection. Done means incorrect login details are not retried indefinitely, while reconnect behavior after a successful connection remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100