crossbario / crossbario/autobahn-python

Public API decorator and public vs private members / ctor

Open
#832 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-discussion
Dominant language
Python
Stars
2.5k
Forks
768
PR merge metrics
No merged PRs in 30d

Description


buildbot.test.unit.test_mq_wamp
  WampMQ
    test_forward_data ...                                               [ERROR]

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/ptardy/dev/bb/buildbot/.venv/lib/python2.7/site-packages/twisted/internet/defer.py", line 1301, in _inlineCallbacks
    result = g.send(result)
  File "/Users/ptardy/dev/bb/buildbot/master/buildbot/test/unit/test_mq_wamp.py", line 135, in test_forward_data
    yield self.mq._produce(('a', 'b'), 'foo')
  File "/Users/ptardy/dev/bb/buildbot/master/buildbot/mq/wamp.py", line 62, in _produce
    return self.master.wamp.publish(self.messageTopic(routingKey), _data, options=options)
  File "/Users/ptardy/dev/bb/buildbot/master/buildbot/test/unit/test_mq_wamp.py", line 70, in publish
    details = EventDetails(1, topic=topic)
exceptions.TypeError: __init__() takes at least 3 arguments (3 given)

investigating..

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing test in buildbot/test/unit/test_mq_wamp.py and the _produce entry point in buildbot/mq/wamp.py. Inspect the EventDetails call in the test and its constructor contract, then determine the intended public versus private API and constructor behavior; the issue is done when the failure is resolved and the relevant test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.