crossbario / crossbario/autobahn-python

Failing tests for RawSocketServerProtocol

Open
#811 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

asyncio bug CI-CD needs-investigation PRIO HIGH
Dominant language
Python
Stars
2.5k
Forks
768
PR merge metrics
No merged PRs in 30d

Description

Hi,

I am in the process of updating autobahn to 0.18.1 for fedora and I encounter failing tests on the build server and on my system. Tests output:

=================================== FAILURES ===================================
_________________________ Test.test_raw_socket_server1 _________________________

self = <test_asyncio_rawsocket.Test testMethod=test_raw_socket_server1>

    def test_raw_socket_server1(self):
    
>       server = RawSocketServerProtocol(max_size=10000)
E       TypeError: __init__() got an unexpected keyword argument 'max_size'

autobahn/asyncio/test/test_asyncio_rawsocket.py:87: TypeError
______________________ Test.test_raw_socket_server_errors ______________________

self = <test_asyncio_rawsocket.Test testMethod=test_raw_socket_server_errors>

    def test_raw_socket_server_errors(self):
    
>       server = RawSocketServerProtocol(max_size=10000)
E       TypeError: __init__() got an unexpected keyword argument 'max_size'

autobahn/asyncio/test/test_asyncio_rawsocket.py:110: TypeError
=============== 2 failed, 161 passed, 1 skipped in 0.53 seconds ================

The tests are defined there and from what I see in the definition of RawSocketProtocol here the max_size parameter doesn't exist which expected. What I find strange is: according to travis everything is fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with autobahn/asyncio/test/test_asyncio_rawsocket.py at test_raw_socket_server1 and test_raw_socket_server_errors, then compare their RawSocketServerProtocol call with the constructor in autobahn/asyncio/rawsocket.py. Run the failing tests and determine whether the test or implementation matches the supported API; done means both failures are resolved without breaking the existing suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.