crossbario / crossbario/autobahn-python
ApplicationSession.onUserError should always be called with IFailedFuture
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 2.5k
- Forks
- 768
- PR merge metrics
- No merged PRs in 30d
Description
At one instance inside wamp/protocol.py onUserError is being called with a "normal" exception instead.
First discussed here https://github.com/crossbario/autobahn-python/pull/1307#discussion_r380165033
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at autobahn/wamp/protocol.py line 825 and read the surrounding onUserError path. Review the linked pull request discussion to confirm the expected IFailedFuture contract, then inspect the relevant existing tests. Done means this call site consistently satisfies the contract and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100