crossbario / crossbario/autobahn-python

DeprecationWarning: time.clock has been deprecated in Python 3.3

Open
#1,308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.5k
Forks
768
PR merge metrics
No merged PRs in 30d

Description

This relates to #1193 which addressed the removal of time.clock but not the deprecation warnings.

venv\lib\site-packages\autobahn\util.py:464
  c:\elns\venv\lib\site-packages\autobahn\util.py:464: DeprecationWarning: time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead
    _ = _rtime()  # this starts wallclock

-- Docs: https://docs.pytest.org/en/latest/warnings.html


Package            Version    Location
------------------ ---------- ----------------------
autobahn           20.1.3

The solution was questioned but the response isn't clear why we need to keep the deprecation warning around. I presume there are some relevant details but I don't know them offhand.

https://github.com/crossbario/autobahn-python/pull/1259#issuecomment-543700872

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading autobahn/util.py around line 464 and the discussion in pull request #1259 to understand why the deprecation warning was retained. Confirm the intended resolution against the reported Python warning; the work is done when the project has a clear, tested outcome for this warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.