crossbario / crossbario/autobahn-python
activation_code missing in wamp.auth.AuthCryptoSign
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.5k
- Forks
- 768
- PR merge metrics
- No merged PRs in 30d
Description
For implementing custom authenticators, one may want to pass "extra information" while connecting. It seems AuthCryptoSign class does not allow that https://github.com/crossbario/autobahn-python/blob/108408cb1c274570e7e06f31427058a7b04c72fc/autobahn/wamp/auth.py#L160
I have a custom authenticator which saves the provided public key to "authorized keys" in my local db if the authextra dictionary contains a valid OTP pin, allowing to use a single wamp connection for pairing and connecting (i.e. no reconnects required)
Does the WAMP spec enforce that or any other reason we do that ? If not, then I'd like to remove that check.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in autobahn/wamp/auth.py at AuthCryptoSign and review the linked implementation alongside the WAMP authentication requirements. Determine whether the activation_code check is required, then ensure custom authenticators can receive the requested authextra information without violating the specification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100