crossbario / crossbario/autobahn-python
XBR: use upstream py-eth-sig-utils
Open
Nobody has claimed this yet.
enhancement
XBR
- Dominant language
- Python
- Stars
- 2.5k
- Forks
- 768
- PR merge metrics
- No merged PRs in 30d
Description
orignally, we had to use our fork https://github.com/crossbario/py-eth-sig-utils because of issues on pypy resulting from dependency on full ethereum.
upstream has merged our PR https://github.com/rmeissner/py-eth-sig-utils/pull/6 - means, we should:
- delete our fork
- depend on the next upstream release
py-eth-sig-utils>=0.4.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect setup.py at the dependency entry linked in the issue and verify how the forked py-eth-sig-utils package is referenced. Update the dependency to py-eth-sig-utils>=0.4.0 and confirm the crossbario fork is no longer needed. Done means the package metadata uses the upstream release and the fork can be deleted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100