crossbario / crossbario/autobahn-python
XBR: fix or replace pysha3 build on PyPy
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.5k
- Forks
- 768
- PR merge metrics
- No merged PRs in 30d
Description
the build fails, see https://gist.github.com/oberstet/fec756b9489a8b046bfd28813bfe2de1
reason: pysha3 uses CPyExt - I have no clue why they did that, nor why they use CPyExt
background: ehtereum uses keccack256 for hashing, a pre-standard sha3-256 variant
the python 3.6+ standard library contains that variant:
New in version 3.6: SHA3 (Keccak) and SHAKE constructors sha3_224(), sha3_256(), sha3_384(), sha3_512(), shake_128(), shake_256().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the PyPy build failure from the linked gist and inspect how pysha3 currently uses CPyExt. Compare that path with the Python 3.6+ standard-library SHA3/Keccak constructors; done means the PyPy build works while Keccak-256 support remains available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100