crossbario / crossbario/autobahn-python

Leaving a Component-attached session or stopping a Component causes infinite connection loop

Open
#1,188 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-discussion
Dominant language
Python
Stars
2.5k
Forks
768
PR merge metrics
No merged PRs in 30d

Description

If a router replies to Autobahn's goodbye with a standards-compliant response like wamp.close.goodbye_and_out, the Component establishes a new connection. This will continue in an infinite loop.

The router's goodbye reply results in the protocol's success callback firing a new "leave" event. This triggers the Component's leave handler, which considers any leaving reason beyond wamp.close.normal to be an error, triggering a new connection somewhere downstream in the Component behaviors.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in autobahn/wamp/protocol.py around line 667 and autobahn/wamp/component.py around line 764, following the goodbye success callback into the Component leave handler. Reproduce shutdown with a standards-compliant wamp.close.goodbye_and_out response and trace the downstream Component behavior. Done means leaving or stopping does not establish an infinite sequence of new connections.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.