crispthinking / crispthinking/athena-python-client
Strongly Typed AthenaError
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 1
- Avg merge
- 22h 52m
- Merged PRs (30d)
- 1
Description
This particular assertion kinda gives me an idea that this test is too tightly coupled to exactly what the error handling logic will do re: strings.
Wonder if it's better to make more, strongly typed, errors that inherit from AthenaError like AthenaAffiliateAuthError or something. Can do that in a way that's not breaking to previous version's code too since they'll except AthenaError.
Originally posted by @snus-kin in https://github.com/crispthinking/athena-python-client/pull/27#discussion_r2371577385
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing AthenaError definition and the error-handling assertion discussed in PR #27. Determine which typed errors are required and verify that callers catching AthenaError remain compatible; completion criteria need agreement because the issue names no specific subclasses or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100