crescentrose / crescentrose/sunshine

Fantastic little tool – two suggestions

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
23
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Thank you for this fantastic little tool. Works great on macOS with CoreLocation. Have already implemented it in a little script of my own. (Will post the link once it's up.)

Two little suggestions. The more important one would be a `--floating` option, i.e. don't show the sunrise and sunset for the current date, but show the previous event and the next two events, depending on the time of day. So at noon (while light) it would look like…

```
last sunrise:

… and e.g. shortly after midnight (while dark) it would look like…

```
last sunset:

The second suggestion (less important) would be the `--apparent` option to calculcate not the astronomical times of sunrise and sunset, but the times of the *apparent* sunrises and sunsets. (Due to light refraction in the atmosphere, apparent sunset is a little later than the real sunset, and apparent sunrise is a little earlier than real sunrise.)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the CLI behavior described for the proposed --floating and --apparent options, then inspect how the tool currently determines and displays sunrise and sunset events. Done means agreeing on the event-selection behavior and apparent-sunrise calculation, implementing both suggestions, and verifying the displayed sequences for daytime and shortly after midnight.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.