creativecommons / creativecommons/search

[bug] Reconsider inclusion/function of Jamendo, terms and filtering are misaligned

Open
#216 1 comment 0 reactions 0 assignees View on GitHub
🏷 status: label work required 💬 talk: discussion 💻 aspect: code 🕹 aspect: interface 🧹 status: ticket work required
Dominant language
CSS
Stars
27
Forks
112
PR merge metrics
No merged PRs in 30d

Description

## Description

_Originally posted by @heyakyra in https://github.com/creativecommons/search/issues/124#issuecomment-1684080259_

>
> > Also, the search returns the "invalid search result: https://www.jamendo.com/search?q=fq" because of the malformed search query.
> >
> > The malformed query may be due to the fact that the [Jamendo](https://www.jamendo.com/search?q=cat) site may have been updated and their search query format updated as well, implying that we may need to update ours in return so as to get expected results.
>
> The current state is broken still, and results in queries like so, where the search terms become `[query-nc] [-nd]` instead of `[query] [-nc] [-nd]`:
>
> ![Screenshot 2023-08-18 at 10-15-33 CC Search Portal](https://github.com/creativecommons/search/assets/740361/dcfc0a1d-34e4-46cc-a8f3-e601d5174990)
> ![Screenshot from 2023-08-18 10-14-54](https://github.com/creativecommons/search/assets/740361/42f4aaa5-7f31-434f-aa87-dfb1f6a15a4a)
>
> And either way, the filters for removing noncommercial and non-derivative licensed results don't work.
>
>
> > So as it stands, the [old Jamendo](https://www.jamendo.com/start) contains music that can be modified, downloaded, and reused (Personal use).
> >
> > And the site [licensing.jamendo](https://licensing.jamendo.com/en/royalty-free-music/search) contains music that can be used for commercial purposes and played in public places.
> >
> > […] So for example, if the user checked the "use for commercial purposes" checkbox, we redirect to [licensing.jamendo](https://licensing.jamendo.com/en/royalty-free-music/search) else we redirect to [old Jamendo](https://www.jamendo.com/start)
>
> This is incorrect, and therefore the solution implemented in #137 is backwards. Jamendo has adopted the language of the music industry oligopoly: "can be used commercially" actually means you can't use it commercially until you buy a license. "can be used personally" means you can use it personally (and maybe commercially too, but it's not in our financial interest to inform you)

## Resolution

- [ ] I would be interested in resolving this bug.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.