creativecommons / creativecommons/creativecommons-base

Determine how best to remove the 24px margin from default page template

Open
#200 6 comments 0 reactions 0 assignees View on GitHub
🏷 status: label work required 💻 aspect: code 🕹 aspect: interface 🚧 status: blocked
Dominant language
PHP
Stars
11
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Currently, the default page template has a `container` class that adds 24px of the bottom margin. This causes an empty white bar to appear between the page content and the footer.

![image](https://user-images.githubusercontent.com/17307/156721183-119509bf-33b8-43aa-812c-a860df832f1a.png)

We added the `content` class with the idea that it would cause typical HTML elements to behave as expected since Bulma contains a `minireset.css` that removes HTML default styles like margin and padding.

It is worth considering that our page template already defines `main-content` and `entry-page-content` elements that may make the Bulma `content` class unnecessary in that context.

![image](https://user-images.githubusercontent.com/17307/156721344-a2b4ac3d-85ba-43e9-92a0-6e309f861a86.png)

## Task

- [ ] determine origin of `main-content` and `entry-page-content` classes
- [ ] determine how best to remove the 24px bottom margin from the page template(s)
- [ ] ensure that default HTML elements from the Gutenberg editor still render as expected

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.