crate / crate/crate-jdbc

Use Testcontainers instead of custom CrateDB integration test helper

Open
#377 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
25
Forks
28
PR merge metrics
No merged PRs in 30d

Description

Hi there,

the [BaseIntegrationTest.java] currently uses `io.crate.testing.CrateTestCluster` and `io.crate.testing.CrateTestServer` from [CrateDB Java Testing Classes]. If it is capable enough to replace this layer, we could now use [Testcontainers for Java » CrateDB support], thanks to @matriv's contribution https://github.com/testcontainers/testcontainers-java/pull/6790, which has been released yesterday.

With kind regards,
Andreas.

[BaseIntegrationTest.java]: https://github.com/crate/crate-jdbc/blob/master/driver/test/java/io/crate/client/jdbc/integrationtests/BaseIntegrationTest.java
[CrateDB Java Testing Classes]: https://github.com/crate/crate-java-testing
[Testcontainers for Java » CrateDB support]: https://www.testcontainers.org/modules/databases/cratedb/

Contributor guide

Open the contributing guide

Research direction

Start with test/java/io/crate/client/jdbc/integrationtests/BaseIntegrationTest.java and compare its use of CrateTestCluster and CrateTestServer with the linked Testcontainers for Java CrateDB support. Verify whether the replacement covers the current integration-test needs, then run the integration tests; done means the custom helper is no longer required and the tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.