crate / crate/crate-admin

Bring back light theme

Open
#709 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
27
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Hi there,

#707 makes the light theme unavailable. However, some people might like it so we might want to bring it back.

> We are using the dark theme as a default now, because all the (former) enterprise plugins only implemented that one.
>
> Because the dynamic plugin loading subsystem only supports regular CSS stylesheets, there is no way to align this with SCSS stylesheets used for the general site. However, to see the UI using the light theme, SCSS variable modifiers are used. So, it will need another iteration to refactor those plugins into regular views to make their stylesheets be able to use SCSS.

The switch is in `app/styles/styles.scss`.
```scss
// TODO: Add a switch for selecting light vs. dark theme.
// @import 'vars/light-theme-variables';
@import 'vars/dark-theme-variables';
```

With kind regards,
Andreas.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.