crashappsec / crashappsec/chalk

add semgrep rule to ensure we are using fd_cache for file handling

Open
#233 0 comments 0 reactions 0 assignees View on GitHub
infrastructure
Dominant language
Nim
Stars
436
Forks
25
PR merge metrics
No merged PRs in 30d

Description

a few issues (ex: https://github.com/crashappsec/chalk/issues/225) have come up due to improper file handling

In chalk, we should always be using the `fd_cache` api to handle files, since it ensures that opened files are actually closed later so that we don't stall on too many files open or try to read from a closed file. To ensure that `fd_cache` is used, we should set up semgrep with a custom rule to check for the usage of other nim file handling and complain if detected.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.