crashappsec / crashappsec/chalk

`chalk docgen` renders HTML tables incorrectly

Open
#178 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Nim
Stars
436
Forks
25
PR merge metrics
No merged PRs in 30d

Description

### Steps to reproduce

Run `chalk docgen` with chalk 0.3.1 or b8a69436a25b2c9cb50f50ce64e4b02cb683eb64.

### Expected behavior

HTML tables are rendered correctly, like:

```html



Command Name
Description


insert
Add chalk marks to artifacts



docgen
Generate technical documentation

```

### Observed behavior

HTML tables are rendered incorrectly, with:

- an extra `` and `` around every cell
- no `` or `` anywhere
- `` at the bottom, where it is invalid (it must be the first child of ``)

like:

```html



Command Name


Description


insert


Add chalk marks to artifacts



docgen


Generate technical documentation

```

This is blocking https://github.com/crashappsec/marketing-site/pull/192.

### Discussion

It looks the bug is in nimutils `rope_htmlrender.nim` [here](https://github.com/crashappsec/nimutils/blob/516dc45ab289e7b132d2ce1e8ae3dc431b885bfe/nimutils/rope_htmlrender.nim#L81-L90).

I believe this is independent of https://github.com/crashappsec/chalk/issues/167.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.