crashappsec / crashappsec/chalk

Consider pinning CI dependencies more strictly

Open
#142 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Nim
Stars
436
Forks
25
PR merge metrics
No merged PRs in 30d

Description

Currently, this is possible:

1. CI passes on a PR
2. We merge the PR
3. CI fails on `main`

I suggest that we should minimize the possibility of this because:

- CI should always be passing on `main`
- PRs are harder to review when there are unrelated CI failures
- It causes a context switch - CI should be fixed before other PRs can be merged

Recently, for example, CI passed on PR https://github.com/crashappsec/chalk/pull/135 but then failed on `main` with https://github.com/crashappsec/chalk/commit/f496958f9e3078f7f52b5e84bfdce5847dee6f26. @miki725 says it's because a new version of semgrep was released. This also caused CI to fail in PR https://github.com/crashappsec/chalk/pull/137.

In this case, can we pin the versions of dependencies like semgrep, and have automated PRs to update them?

Alternatively, the problem is alleviated somewhat if we use a merge queue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.