craftcms / craftcms/commerce

First name with hyphen is merged into last name after save

Open
#3,480 4 comments 0 reactions 1 assignee View on GitHub

@lukeholder is already working on this.

Since May 6, 2024.

commerce4 Craft Commerce severity:minor
Dominant language
PHP
Stars
240
Forks
173
Avg merge
5d 11h
Merged PRs (30d)
8

Description

What happened?
Description

When submitting separate first name and last name on the checkout then when the first name contains a hyphen "-" then after save the first name is blank the last name field contains the first name and last name.

Steps to reproduce
  1. submit first name and last name separately
  2. Make sure first name contains a hyphen "-" .e.g. "Chi-la".
  3. Last name can be anything e.g. "Smith"
  4. Submit the form.
  5. Refresh and now the first name field is empty and the last name contains "Chi-la Smith"
Expected behavior

I would expect first name field contains "Chi-la" and last name contains "Smith.

WARNING! Stripe does not not support hyphen "-" in the name so perhaps better to output this:

First name: "Chi la"
Last name: "Smith

Alternatively strip the hyphen "-" from the stripe payment request generation.

I noticed this issue as a customer couldn't pay due to Stripe having a JS error.
Uncaught (in promise) TypeError: paymentResponse.redirectData is undefined
due to no first name stored on the order.

Actual behavior

First name: (blank)
Last name: "Chi-la Smith"

Craft CMS version

4.8.10

Craft Commerce version

4.5.4

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.