craftcms / craftcms/cms

(non-breaking) inaccurate in-cp store credit card error flash message

Open
#7,635 0 comments 0 reactions 1 assignee View on GitHub

@benjamindavid is already working on this.

Since Mar 1, 2021.

bug
Dominant language
PHP
Stars
3.6k
Forks
705
Avg merge
1d 5h
Merged PRs (30d)
134

Description

Description

If the wrong CC credentials are used in the in-CP store (in my case it was the wrong card holder), a "couldn't save payment method" error is given regardless of whether the user is asking to save the payment info.

Took me a minute to figure out that the cardholder information was the problem — looked like the bug was Craft getting confused about whether or not to save the payment info.

Steps to reproduce
  1. Make a purchase in the plugin store (in my case it was a Craft Pro license). Enter the wrong card holder information. Don't ask to save payment info. Submit
  2. See that the error message seems to think you wanted to save payment info

image

Additional info
  • Craft version: 3.6.6
  • PHP version: 7.4.15
  • Database driver & version: MySQL 8.0.23
  • Plugins & versions:
    image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.