craftcms / craftcms/cms

Deprecation errors being thrown for resolved errors from within the vendor dir

Open
#7,039 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
3.6k
Forks
705
Avg merge
1d 5h
Merged PRs (30d)
134

Description

Description

I had a deprecation error once upon a time and resolved it. However, I am constantly getting a ghost of that deprecation error from within my /vendor directory.

/home/vagrant/<client>/_project/_craft/vendor/craftcms/cms/src/elements/db/EntryQuery.php:228

Is there any way for deprecation errors to not be flagged if they're from within the vendor directory?

Note that this error is the following:

The order element query param has been deprecated. Use orderBy instead.
Additional info
  • Craft version: 3.5.13.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with vendor/craftcms/cms/src/elements/db/EntryQuery.php at line 228 and trace how the deprecated order query parameter is reported. Review the issue's deprecation-error handling path and determine how vendor-originated notices are identified. Done means resolved deprecation notices from the vendor directory are no longer surfaced, while relevant application notices remain visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.