Multiple calls to \craft\services\Assets::moveAsset() in same request

Description

What I am trying to do is renumber all filenames of of a particular folder so they are in a sequential order (in this case, the order that they are set in when they appear in an asset field for a particular entry). This has to be a 2 step process. i.e. rename all files to a temporary name and then rename them back to the desired name. This is to avoid conflicting filenames.

The first time a call is made like: Craft::$app->getAssets()->moveAsset(...) it works. If you call the same function again on the same asset in the same request you get undefined (difficult to pin down) behaviour.

The effect depends on what the particular case is, but usually some files get renamed and others do not. Sometimes assets appear to swap the associated file on the filesystem.

I believe this happens because moveAsset() essentially, just calls Craft::$app->getElements()->saveElement(...) after setting some things up. When the asset is saved, the file operation of actually moving the file happens in an afterSave() event / hook / call on the Asset element, therefore something not sure what yet, changes during the file-op and is not updated (i.e. saved) in the AssetRecord which would already have been saved.

It can be worked around by explicitly reloading the asset before doing the second call of moveAsset() with something like: $asset = Asset::find()->id($asset->id)->one() but it's not very performant .

Steps to reproduce

1. Have a folder in a volume with multiple files as assets
2. Call Craft::$app->getAssets()->moveAsset(...) on each of them with random filename
3. Call Craft::$app->getAssets()->moveAsset(...) again on each going back to sequential filenames

Additional info

• Craft version: 3.4.10.1
• PHP version: 7.4.4
• Database driver & version: MySQL 5.7.29
• Plugins & versions: N/A